-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pages.zh/osx: add Chinese translation #2796
Conversation
4d51515
to
af6ee52
Compare
@agnivade |
It's not actually. Sorry if I was not able to explain. I want each page translation to have its own commit. And there should not be any merge commit in the branch. What you have currently is also "okay", but we prefer to have a separate commit for each page to keep things clean. |
pages.zh/linux/apache2ctl.md
Outdated
@@ -0,0 +1,24 @@ | |||
# apache2ctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm. Did you mean to translate this page? It looks like English to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it !
Hi! I changed each page translation to its own commit. |
The commits look good. /cc @HugueLiu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @wizarot!
The contents in {{}} should also be translated. @wizarot |
@HugueLiu oh you're right, we totally missed that. |
Hello @wizarot and others, With this workflow:
|
Yes, it may require extra work to move translations to a |
I can help to move existing translations to .po files, if the final decision will be made to use .po for translations. There are some command line tool for this and I have experiences about its usage. |
That's great @urbalazs ! Thanks for helping us out with this. The final decision is indeed to use .po files. But since this is a new workflow, one of us need to own and understand it. @mebeim has graciously offered to lead this, but he needs some time. Let us continue with the existing workflow until then. |
I translated the contents in {{}} . @HugueLiu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @wizarot 😺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
common/
,linux/
, etc.)